Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Doc: Search Control - add Storybook link #56815

Merged
merged 3 commits into from
Dec 11, 2023
Merged

Doc: Search Control - add Storybook link #56815

merged 3 commits into from
Dec 11, 2023

Conversation

bph
Copy link
Contributor

@bph bph commented Dec 6, 2023

What?

Documentation page for Search Control is linked in Data Layer Course on Learn.WordPress and need a link to the Storybook space.

Why?

It would help a learner to know about Storybook space for more visual exploration of components.

How?

added the link to the readme.md for the component

Testing Instructions

Use the View file feature

@bph bph added [Type] Developer Documentation Documentation for developers [Package] Components /packages/components labels Dec 6, 2023
@bph bph self-assigned this Dec 6, 2023
@bph bph requested a review from ajitbohra as a code owner December 6, 2023 10:10
@bph bph marked this pull request as draft December 6, 2023 10:10
@bph bph marked this pull request as ready for review December 6, 2023 10:22
@github-actions GitHub Actions
Copy link

github-actions bot commented Dec 6, 2023 •
edited
Loading

Flaky tests detected in 5306bea.
Some tests passed with failed attempts. The failures may not be related to this commit but are still reported for visibility. See the documentation for more information.

🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/7125313839
📝 Reported issues:

apeatling
apeatling approved these changes Dec 7, 2023
View reviewed changes
Copy link
Contributor

@apeatling apeatling left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@apeatling
Copy link
Contributor

@bph I think the spinner PR changed the wrong file looking at it now. It updated the search control doc. It's cause a conflict here. I've opened #56913 to revert that, and a new PR can be opened that updates the spinner control doc.

@bph
Copy link
Contributor Author

bph commented Dec 10, 2023

I guess I goofed things, sorry about the extra work for such a minor thing. Thanks for watching over me, @apeatling

@apeatling apeatling merged commit 275e833 into trunk Dec 11, 2023
51 of 52 checks passed
@apeatling apeatling deleted the doc/add-storybook-link branch December 11, 2023 18:17
@github-actions github-actions bot added this to the Gutenberg 17.3 milestone Dec 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@apeatling apeatling apeatling approved these changes

@ajitbohra ajitbohra Awaiting requested review from ajitbohra ajitbohra is a code owner

Assignees

@bph bph

Labels
[Package] Components /packages/components [Type] Developer Documentation Documentation for developers
Projects
None yet
Milestone
Gutenberg 17.3
Development

Successfully merging this pull request may close these issues.
2 participants
@bph @apeatling